Re: LLVM compile failing in seawasp - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: LLVM compile failing in seawasp
Date
Msg-id CA+hUKG+vW2BHoJXJYhzBpzwC-pH854MguThsLewLcGh4pst0Jg@mail.gmail.com
Whole thread Raw
In response to Re: LLVM compile failing in seawasp  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: LLVM compile failing in seawasp  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
On Sat, Jul 27, 2019 at 7:12 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> On Sat, Jul 27, 2019 at 7:06 PM Fabien COELHO <coelho@cri.ensmp.fr> wrote:
> > Maybe we should consider doing an explicit bug report, but I would not bet
> > that they are going to fold… or fixing the issue pg side, eg "pg_Min",
> > less than 400 hundred instances, and backpatch to all supported
> > versions:-(
>
> I would just #undef Min for our small number of .cpp files that
> include LLVM headers.  It's not as though you need it in C++, which
> has std::min() from <algorithm>.

Like so.  Fixes the problem for me (llvm-devel-9.0.d20190712).

--
Thomas Munro
https://enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: LLVM compile failing in seawasp
Next
From: Julien Rouhaud
Date:
Subject: Re: Add parallelism and glibc dependent only options to reindexdb