Request a Demo
Home   >   mailing lists

Re: Fix uninitialized xl_running_xacts padding - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Fix uninitialized xl_running_xacts padding
Date
Msg-id CA+hUKG++LE6P6g4n+-QPHBwAnvcVRyG1tUnzscUriWAFHc6s6Q@mail.gmail.com
Whole thread Raw
In response to Fix uninitialized xl_running_xacts padding  (Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>)
Responses Re: Fix uninitialized xl_running_xacts padding
List pgsql-hackers
Tree view 
On Fri, Feb 13, 2026 at 10:39 PM Anthonin Bonnefoy
<anthonin.bonnefoy@datadoghq.com> wrote:
> The 3 bytes of padding after subxid_overflow were left uninitialized,
> leading to the random 'ca ce 9b' data being written in the WAL. The
> attached patch fixes the issue by zeroing the xl_running_xacts
> structure in LogCurrentRunningXacts using MemSet.

Nitpick: the so-called universal zero initialiser syntax (var = {0})
is a nicer way to do this and generally preferred in new code AFAIK.

But in this case, it seems we don't actually worry about initialising
WAL padding bytes in general.  valgrind.supp has an entry to prevent
warnings about it.  Should we?

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Fix uninitialized xl_running_xacts padding
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Improve docs syntax checking and enable it in the meson build