Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Remove dependency on HeapTuple from predicate locking functions. - Mailing list pgsql-committers

From Thomas Munro
Subject Re: pgsql: Remove dependency on HeapTuple from predicate locking functions.
Date
Msg-id CA+hUKG++GRiv1ELbt8DW4Tw117SiV1EXE_Yc2j8d6JW8xmTDzw@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Remove dependency on HeapTuple from predicate locking functions.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Remove dependency on HeapTuple from predicate locking functions.
List pgsql-committers
Tree view 
On Tue, Jan 28, 2020 at 6:59 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Thomas Munro <tmunro@postgresql.org> writes:
> > Remove dependency on HeapTuple from predicate locking functions.
>
> anole's not terribly pleased with this:
>
> "heapam.c", line 9137: error #2118: a void function may not return a value
>         return CheckForSerializableConflictOut(relation, xid, snapshot);
>                ^

Thanks.  I pushed a fix.

Wow, HP C spits out a lot of warnings.

pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Fix compile error on HP C.
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix randAccess setting in ReadRecord()