Re: [PATCH] Warn when io_min_workers exceeds io_max_workers - Mailing list pgsql-hackers

From Baji Shaik
Subject Re: [PATCH] Warn when io_min_workers exceeds io_max_workers
Date
Msg-id CA+fm-RP8wjzJRVAVm8HzymO6FJ_3_-Q9Xn115jA6tKDTEgm-Pg@mail.gmail.com
Whole thread
Responses Re: [PATCH] Warn when io_min_workers exceeds io_max_workers
List pgsql-hackers
On Mon, Jun 22, 2026 at 8:29 PM Michael Paquier <michael@paquier.xyz> wrote:
Let's adjust the messages so as the GUC parameters are included as %s
in the error strings, and apply the same thing for the autovacuum
path.  A benefit is that we are then able to reduce the translation
work churn with only one message to translate for both.  Hence, I'd
suggest to reword the error messages of both as of:
"\"%s\" (%d) should be less than or equal to \"%s\" (%d)",
"guc_max_min", min_val, "guc_min_name", max_val

Thanks for the suggestion, Michael.

Attached v2 with two patches:

0001 - Adds check_io_worker_gucs() with parameterized GUC names (%s)
0002 - Adjusts check_av_worker_gucs() to use the same format

Both now produce the same translatable errmsg pattern:
 "\"%s\" (%d) should be less than or equal to \"%s\" (%d)"

Thanks, 
Baji Shaik. 
Attachment

pgsql-hackers by date:

Previous
From: Xuneng Zhou
Date:
Subject: Re: 048_vacuum_horizon_floor.pl hangs due to wakeup lost inside LockBufferForCleanup
Next
From: Richard Guo
Date:
Subject: Re: Remove inner joins based on foreign keys