Request a Demo
Home   >   mailing lists

Re: [PATCH] COPY TO FORMAT json: respect column list order - Mailing list pgsql-hackers

From Baji Shaik
Subject Re: [PATCH] COPY TO FORMAT json: respect column list order
Date
Msg-id CA+fm-RP4tX6rCq16GzDLGnAY974oLk6JBtSurk0iTNi8FnQedg@mail.gmail.com
Whole thread
In response to Re: [PATCH] COPY TO FORMAT json: respect column list order  (Sami Imseih <samimseih@gmail.com>)
Responses Re: [PATCH] COPY TO FORMAT json: respect column list order
List pgsql-hackers
Tree view
On Sat, Jun 13, 2026 at 6:07 PM Sami Imseih <samimseih@gmail.com> wrote:
This comment is not needed.

But I think we should add a comment explaining the condition here.

Done, replaced with a short comment above the condition and
dropped the inner block comment. 

Should we just add tests for all the output types?

Added. v2 has column-reorder tests for text and csv (before the
JSON section) plus subset and reorder tests for JSON in the JSON
section.

Thanks for the review, Sami. And thanks Andrew for the +1.

v2 attached. 
Attachment

pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: Fix unqualified catalog references in psql describe queries
Next
From: Nathan Bossart
Date:
Subject: Re: fix prev link in docs