Request a Demo
Home   >   mailing lists

Re: [PATCH] Fix memory leak in pgstat_progress_parallel_incr_param() - Mailing list pgsql-hackers

From Baji Shaik
Subject Re: [PATCH] Fix memory leak in pgstat_progress_parallel_incr_param()
Date
Msg-id CA+fm-RNJTNqMFEbk1Fib5i1261PYqJTJBbvNYjyyNqRNnPJjSQ@mail.gmail.com
Whole thread
In response to Re: [PATCH] Fix memory leak in pgstat_progress_parallel_incr_param()  (Sami Imseih <samimseih@gmail.com>)
List pgsql-hackers
Tree view
On Sat, Jun 6, 2026 at 9:55 AM Sami Imseih <samimseih@gmail.com> wrote:
>   0002: allocate the static buffer once per process via
>         pq_beginmessage_reuse / pq_endmessage_reuse, to avoid the
>         per-call allocation (master only)

I am less convinced this will have any benefits for the additional complexity.
The callers of pgstat_progress_parallel_incr_param() are not frequent enough
to make a measurable difference here. cost delay reporting for parallel workers
is throttled by PARALLEL_VACUUM_DELAY_REPORT_INTERVAL_NS and
index progress reporting does not happen very frequently either.

Thanks for the review, Sami.

Agreed, at those call frequencies the per-call palloc is not worth
the added complexity. Dropping 0002. 

v3 attached (just 0001, unchanged from previous).

Thanks,
Baji Shaik.
Attachment

pgsql-hackers by date:

Previous
From: Sami Imseih
Date:
Subject: Re: [PATCH] Fix memory leak in pgstat_progress_parallel_incr_param()
Next
From: 신성준
Date:
Subject: Re: Add wait events for server logging destination writes