Also, "Re-check" in the second call-site comment feels a bit vague to me, since the previous call is quite far away. Perhaps both call-site comments could simply describe checking the relevant GUC values, one at startup and the other after a configuration reload. Regards,
Thanks for the review.
Attached v3 with both comments updated to /* Emit a WARNING if io_min_workers > io_max_workers. */ as suggested.
I have kept the autovacuum message change as 0002 since Michael suggested unifying the format strings. If the consensus is to
leave the existing autovacuum message alone, I'm happy to drop it.