Postgres Pro
Downloads
Home   >   mailing lists

Re: Resetting spilled txn statistics in pg_stat_replication - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: Resetting spilled txn statistics in pg_stat_replication
Date
Msg-id CA+fd4k4Rx3rn+fNJG6Yd8+6afnT+u_BwWFo2vNrbVQ3yq4NQJA@mail.gmail.com
Whole thread Raw
In response to RE: Resetting spilled txn statistics in pg_stat_replication  ("Shinoda, Noriyoshi (PN Japan A&PS Delivery)" <noriyoshi.shinoda@hpe.com>)
List pgsql-hackers
Tree view 
On Wed, 14 Oct 2020 at 12:03, Shinoda, Noriyoshi (PN Japan A&PS
Delivery) <noriyoshi.shinoda@hpe.com> wrote:
>
> Thanks for your comment.
>
> > 8.3. Character Types:
> > The name type exists only for the storage of identifiers in the internal system catalogs
>
> I didn't know the policy about data types. Thank you.
> But I think the column names should match pg_replication_slots.
> The attached patch changes only the column names and macros.
>

Thank you for updating the patch!

The patch changes the column name from 'name' to 'slot_name' and fixes
a typo. That's reasonable to me. Amit, what do you think?

Regards,

-- 
Masahiko Sawada            http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: speed up unicode decomposition and recomposition
Next
From: Julien Rouhaud
Date:
Subject: Re: Online checksums verification in the backend