Re: [PATCH] Porting small OpenBSD changes. - Mailing list pgsql-hackers

From David CARLIER
Subject Re: [PATCH] Porting small OpenBSD changes.
Date
Msg-id CA+XhMqyKp+g5pA5tojqCKNa8rjx3_4ESZJ_fQweJ8n4kNdN1oA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Porting small OpenBSD changes.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Porting small OpenBSD changes.  (David Fetter <david@fetter.org>)
Re: [PATCH] Porting small OpenBSD changes.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers


On 20 November 2017 at 18:49, Tom Lane <tgl@sss.pgh.pa.us> wrote:
David CARLIER <devnexen@gmail.com> writes:
> - Reducing OpenBSD postfgresql maintainer internal changes bookeeping if
> those small changes make sense for the PostgreSQL developers.

Hm.  The s_lock.c change is surely fine if OpenBSD maintainers say it is.

Not sure about adding Motorola 88K support to s_lock.h ... is anybody
really still interested in that platform? 

Yes there is :-)
 
OTOH, we still have M68K
and VAX stanzas in that file, so I suppose it's silly to complain
about 88K.  A bigger issue is that I wonder whether that code has
ever been tested: it does not look to me like the __asm__ call is
even syntactically correct.  There should be colons in it.


True :-) corrected. Thanks.
 
                        regards, tom lane

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Porting small OpenBSD changes.
Next
From: Fabrízio de Royes Mello
Date:
Subject: Re: [HACKERS] [PATCH] A hook for session start