so, it sounds like you're saying our accaptable_test_db is unacceptable :-P
here's a patch that takes an "--exclude" flag (see README) and doesn't create dbs that don't get cleaned up afterwards
On Fri, Jan 27, 2017 at 11:28 AM, Dave Page <dpage@pgadmin.org> wrote:
On Fri, Jan 27, 2017 at 4:11 PM, Dave Page <dpage@pgadmin.org> wrote: > On Thu, Jan 26, 2017 at 10:40 PM, George Gelashvili > <ggelashvili@pivotal.io> wrote: >> instead of that patch, please use this no-zombies version that kills the >> started process group instead of pid-only. > > Very cool :-). The only minor annoyance for me is that my Mac pops up > a message asking me if I want pgAdmin to accept connections, but > there's nothing you can do about that of course. > > At this point I think there are a couple of things left to do; > > - Add more tests! > > - Add command line options to runtests.py to allow users to run either > the existing tests or the acceptance tests (or both, which should be > the default). Of course, it should still be possible to just run any > single test.
Please add:
- Proper cleanup. I just noticed the tests have left an "acceptable_test_db" database behind.
