Re: Unarchived WALs deleted after crash - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Unarchived WALs deleted after crash
Date
Msg-id CA+U5nML55uusMTENGr=bkO35GFEqgO=sWCdktJuoOdt_5XDb9w@mail.gmail.com
Whole thread Raw
In response to Re: Unarchived WALs deleted after crash  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On 15 February 2013 16:10, Fujii Masao <masao.fujii@gmail.com> wrote:

>> I propose the attached patch to fix it.
>
> At least in 9.2, when the archived file is restored into pg_xlog, its xxx.done
> archive status file is created. So we don't need to check InArchiveRecovery
> when deleting old WAL files. Checking whether xxx.done exists is enough.

I don't agree. The extra test Heikki put in was useful and helps avoid
issues when we get the .done creation wrong, or when people delete
them.

-- Simon Riggs                   http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Materialized views WIP patch
Next
From: Atri Sharma
Date:
Subject: Re: [pgsql-advocacy] Call for Google Summer of Code mentors, admins