Re: Add shutdown_at_recovery_target option to recovery.conf - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Add shutdown_at_recovery_target option to recovery.conf
Date
Msg-id CA+U5nMK-Y5Bd2riohBu=JOfO+OWssb89QadbGqP3JeP3AbfWAA@mail.gmail.com
Whole thread Raw
In response to Re: Add shutdown_at_recovery_target option to recovery.conf  (Petr Jelinek <petr@2ndquadrant.com>)
List pgsql-hackers
On 19 November 2014 22:47, Petr Jelinek <petr@2ndquadrant.com> wrote:
> On 19/11/14 19:51, Simon Riggs wrote:
>>
>> On 19 November 2014 16:11, Petr Jelinek <petr@2ndquadrant.com> wrote:
>>
>>>> We need to be able to tell the difference between a crashed Startup
>>>> process and this usage.
>>>>
>>>> As long as we can tell, I don't mind how we do it.

...

> Ok this seems ok, I did couple of fixes - used exit code 3 as 2 is used in
> some places - given the "if (pid == StartupPID)" it would probably never
> conflict in practice, but better be safe than sorry in this case IMHO.
> And you forgot to actually set the postmaster into one of the Shutdown
> states so I added that.

Like it.

Patch looks good now. Will commit shortly.

-- Simon Riggs                   http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [PATCH] add ssl_protocols configuration option
Next
From: Alex Shulgin
Date:
Subject: Re: [PATCH] add ssl_protocols configuration option