On Thu, Dec 11, 2014 at 3:47 PM, Jeff Janes <jeff.janes@gmail.com> wrote:
> I agree. Having your patch disappear into the void is not friendly at all.
> But I don't think a commentless "-1" is the answer, either. That might one
> of the few things worse than silence. Even if the comment is just "This
> seems awfully complicated for a minimally useful feature" or "This will
> probably have unintended side effects in the executor that I don't have time
> to trace down, can someone make an argument for correctness", or even "this
> format is unreadable, I won't review this until it is fixed" then at least
> the author (and perhaps more important, junior contributors who are not the
> author) will know either what argument to make to lobby for it, what avenue
> to take when reviewing it, or whether to just forget it and work on
> something more important.
Agreed!
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
