Re: Generalize ereport_startup_progress infrastructure - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Generalize ereport_startup_progress infrastructure
Date
Msg-id CA+Tgmobg5Hchwm9arFaJYWamOmuufT3R_KsGxuqdx1VPwXu8PA@mail.gmail.com
Whole thread Raw
In response to Re: Generalize ereport_startup_progress infrastructure  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Generalize ereport_startup_progress infrastructure
List pgsql-hackers
On Mon, Aug 8, 2022 at 12:29 AM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
> Here's v2 patch, passing progress report interval as an input to
> begin_progress_report_phase() so that the processes can use their own
> intervals(hard-coded or GUC) if they wish to not use the generic GUC
> log_progress_report_interval.

I don't think we should rename the GUC to be more generic. I like it
the way that it is.

I also think you should extend this patch series with 1 or 2
additional patches showing where else you think we should be using
this infrastructure.

If no such places exist, this is pointless.

-- 
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: support for MERGE
Next
From: Andrew Dunstan
Date:
Subject: Re: [RFC] building postgres with meson