Re: Small patch: fix code duplication in heapam.c - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Small patch: fix code duplication in heapam.c
Date
Msg-id CA+TgmobfAFvZd7ysdFxmHwkj_8HqmCLsdfKSHJNmHUVdqd1-xg@mail.gmail.com
Whole thread Raw
In response to Re: Small patch: fix code duplication in heapam.c  (Aleksander Alekseev <a.alekseev@postgrespro.ru>)
Responses Re: Small patch: fix code duplication in heapam.c
List pgsql-hackers
On Thu, Mar 24, 2016 at 11:35 AM, Aleksander Alekseev
<a.alekseev@postgrespro.ru> wrote:
> In the same time I'm deeply convinced that this patch will make code
> more readable at least because it makes code much shorter:

I think this is a waste of time.  These functions are already very
short; making them shorter will not significantly improve readability.
It'll just force people who think they know what that code does to
look at it again to see if it still does the same thing.

Let's spend our time arguing about changes that matter.  There are an
infinite number of things like this that you could tinker with, but
most of them are not worth tinkering with.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: VS 2015 support in src/tools/msvc
Next
From: Robert Haas
Date:
Subject: Re: Small patch: Change calling convention for ShmemInitHash (and fix possible bug)