Postgres Pro
Downloads
Home   >   mailing lists

Re: trying again to get incremental backup - Mailing list pgsql-hackers

From Robert Haas
Subject Re: trying again to get incremental backup
Date
Msg-id CA+TgmobdU8Xa3bsU7F==U0vAS1KfkgvAnskjnSqagUB2gGFrcw@mail.gmail.com
Whole thread Raw
In response to Re: trying again to get incremental backup  (Alexander Lakhin <exclusion@gmail.com>)
Responses Re: trying again to get incremental backup
List pgsql-hackers
Tree view 
On Wed, Dec 20, 2023 at 11:00 PM Alexander Lakhin <exclusion@gmail.com> wrote:
> I've found several typos/inconsistencies introduced with 174c48050 and
> dc2123400. Maybe you would want to fix them, while on it?:

That's an impressively long list of mistakes in something I thought
I'd been careful about. Sigh.

I don't suppose you could provide these corrections in the form of a
patch? I don't really want to run these sed commands across the entire
tree and then try to figure out what's what...

> Also, a comment above MaybeRemoveOldWalSummaries() basically repeats a
> comment above redo_pointer_at_last_summary_removal declaration, but
> perhaps it should say about removing summaries instead?

Wow, yeah. Thanks, will fix.

--
Robert Haas
EDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Detecting some cases of missing backup_label
Next
From: shveta malik
Date:
Subject: Re: Track in pg_replication_slots the reason why slots conflict?