Re: [COMMITTERS] pgsql: In checkpoint, move the check for in-progress xacts out of criti - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [COMMITTERS] pgsql: In checkpoint, move the check for in-progress xacts out of criti
Date
Msg-id CA+Tgmobcm+ZAMD7Evpi+MJJ8bMQQy=UYU0E-f4nrdzr1PC_XEA@mail.gmail.com
Whole thread Raw
Responses Re: Re: [COMMITTERS] pgsql: In checkpoint, move the check for in-progress xacts out of criti  (Heikki Linnakangas <hlinnakangas@vmware.com>)
List pgsql-hackers
On Fri, Apr 4, 2014 at 10:32 AM, Heikki Linnakangas
<heikki.linnakangas@iki.fi> wrote:
> In checkpoint, move the check for in-progress xacts out of critical section.
>
> GetVirtualXIDsDelayingChkpt calls palloc, which isn't safe in a critical
> section. I thought I covered this case with the exemption for the
> checkpointer, but CreateCheckPoint is also called from the startup process.

This commit un-broke "make check", which you might have wanted to run
before committing, but "make -C src/test/isolation check" is still
broken.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: integrate pg_upgrade analyze_new_cluster.sh into vacuumdb
Next
From: Andres Freund
Date:
Subject: Re: GiST support for inet datatypes