Re: copyParamList - Mailing list pgsql-hackers

From Robert Haas
Subject Re: copyParamList
Date
Msg-id CA+TgmobW+-1KYtTyAsxiSLZAKwf-c+69tFJbzBPfYdWZ2DTkZw@mail.gmail.com
Whole thread Raw
In response to Re: copyParamList  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
List pgsql-hackers
On Wed, Jul 27, 2016 at 12:25 AM, Andrew Gierth
<andrew@tao11.riddles.org.uk> wrote:
>>>>>> "Robert" == Robert Haas <robertmhaas@gmail.com> writes:
>  Robert> So I think we instead ought to fix it as in the attached.
>
>  Robert>                if (retval->paramMask != NULL &&
>  Robert> -                      !bms_is_member(i, retval->paramMask))
>  Robert> +                      !bms_is_member(i, from->paramMask))
>
> Need to change both references to retval->paramMask, not just one.

You are, of course, entirely correct.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Vik Fearing
Date:
Subject: Re: PoC: Make it possible to disallow WHERE-less UPDATE and DELETE
Next
From: Robert Haas
Date:
Subject: Re: copyParamList