Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] increasing the default WAL segment size - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] increasing the default WAL segment size
Date
Msg-id CA+TgmobTJ1hSJNy4fjbA5eqqVvVi-gC7adJk9Uez9oDSMHSHrg@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] increasing the default WAL segment size  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [HACKERS] increasing the default WAL segment size  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Tree view 
On Thu, Jan 26, 2017 at 8:53 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
>> I've not done like the most careful review ever, but I'm in favor of the
>> general change (provided the byval thing is fixed obviously).
>
> Thanks for the review.

Why not use pg_ltoa and pg_lltoa like the output functions for the datatype do?

Might use CStringGetTextDatum(blah) instead of
PointerGetDatum(cstring_to_text(blah)).

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Typo in comment in postgres_fdw.c
Next
From: Jim Nasby
Date:
Subject: Re: [HACKERS] Proposal : For Auto-Prewarm.