Postgres Pro
Downloads
Home   >   mailing lists

Re: making bgworkers without shmem access actually not have shmem access - Mailing list pgsql-hackers

From Robert Haas
Subject Re: making bgworkers without shmem access actually not have shmem access
Date
Msg-id CA+TgmobCevERwcso6WEFE=+vg3a0b34+7YDEWgjbVdL0SWLC2g@mail.gmail.com
Whole thread Raw
In response to Re: making bgworkers without shmem access actually not have shmem access  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On Wed, May 7, 2014 at 2:44 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> I've complained about this problem a few times before: there's nothing
>> to prevent a background worker which doesn't request shared memory
>> access from calling InitProcess() and then accessing shared memory
>> anyway.  The attached patch is a first crack at fixing it.
>
>> Comments?
>
> Looks reasonable to me.

Thanks for the fast review.  Committed, after fixing one further bug I spotted.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: proposal: Set effective_cache_size to greater of .conf value, shared_buffers
Next
From: Peter Geoghegan
Date:
Subject: Re: proposal: Set effective_cache_size to greater of .conf value, shared_buffers