Re: [HACKERS] Fix a typo in execReplication.c - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] Fix a typo in execReplication.c
Date
Msg-id CA+TgmobAZvCxduG8y_mQKBK7nz-vhbdLvjM354KEFozpuzMN5A@mail.gmail.com
Whole thread Raw
In response to [HACKERS] Fix a typo in execReplication.c  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: [HACKERS] Fix a typo in execReplication.c
List pgsql-hackers
On Mon, Oct 9, 2017 at 10:59 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> Attached a patch for $subject. ISTM these are mistakes of copy-and-paste.

Committed, but isn't the code itself wrong as well in the DELETE case?
   /* BEFORE ROW DELETE Triggers */   if (resultRelInfo->ri_TrigDesc &&
resultRelInfo->ri_TrigDesc->trig_update_before_row)  {       skip_tuple = !ExecBRDeleteTriggers(estate, epqstate,
resultRelInfo,                                         &searchslot->tts_tuple->t_self,
       NULL);   }
 

Why not trig_delete_before_row?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] SendRowDescriptionMessage() is slow for queries with alot of columns
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] Pluggable storage