Re: Minor fix in reloptions.c comments - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Minor fix in reloptions.c comments
Date
Msg-id CA+Tgmob5P5rVnJavME7SJq=ksbBRG7vydVA+QKccHZmik134bg@mail.gmail.com
Whole thread Raw
In response to Re: Minor fix in reloptions.c comments  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Fri, Apr 12, 2019 at 12:01 AM Michael Paquier <michael@paquier.xyz> wrote:
> On Fri, Apr 12, 2019 at 02:41:37AM +0000, Jamison, Kirk wrote:
> > I found some minor grammar mistake while reading reloptions.c code comments.
> > Attached is the fix.
> > I just changed "affect" to "effect", for both n_distinct and vacuum_truncate.
> >   - * values has no affect until the ...
> >   + * values has no effect until the ...
>
> A lot of those parameter updates affect processing and still they have
> many side effects, as per those paragraphs.

Well, "has no affect" is clearly wrong here, and Kirk's fix is clearly
right.  I don't know what your point here is.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Zedstore - compressed in-core columnar storage
Next
From: Ashwin Agrawal
Date:
Subject: Re: Zedstore - compressed in-core columnar storage