Re: [PATCH] Improve bytea error messages - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [PATCH] Improve bytea error messages
Date
Msg-id CA+TgmoauwBR3mxKq3C7z+4dPjSQj1y9Pw8eikGP0mrxSk7vJzQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Improve bytea error messages  (Craig Ringer <craig@2ndquadrant.com>)
List pgsql-hackers
On Tue, Jul 8, 2014 at 12:49 AM, Craig Ringer <craig@2ndquadrant.com> wrote:
> On 07/08/2014 07:44 AM, Robert Haas wrote:
>> On Sun, Jul 6, 2014 at 4:17 AM, Craig Ringer <craig@2ndquadrant.com> wrote:
>>> After someone reported somewhat less than informative errors in bytea
>>> decoding (http://stackoverflow.com/q/24588866/398670) I thought I'd put
>>> together a quick patch to improve the errors here.
>>
>> The first two changes seem fine from here, but I think the use of
>> parentheses in the third one likely violates our message style
>> guidelines.
>
> Good point.
>
> Better?
>
> Putting it in ERRHINT is more appropriate.

Looks OK to me.  Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Christoph Berg
Date:
Subject: Re: postgresql.auto.conf and reload
Next
From: Robert Haas
Date:
Subject: Re: Doing better at HINTing an appropriate column within errorMissingColumn()