Re: some grammar refactoring - Mailing list pgsql-hackers

From Robert Haas
Subject Re: some grammar refactoring
Date
Msg-id CA+Tgmoat8A2asWk3FygnvS9fdTPw7L-NybWG6toU80c3Mtb9ig@mail.gmail.com
Whole thread Raw
In response to some grammar refactoring  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
On Tue, May 19, 2020 at 2:43 AM Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
> Here is a series of patches to do some refactoring in the grammar around
> the commands COMMENT, DROP, SECURITY LABEL, and ALTER EXTENSION ...
> ADD/DROP.  In the grammar, these commands (with some exceptions)
> basically just take a reference to an object and later look it up in C
> code.  Some of that was already generalized individually for each
> command (drop_type_any_name, drop_type_name, etc.).  This patch combines
> it into common lists for all these commands.

I haven't reviewed the code, but +1 for the idea.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Two fsync related performance issues?
Next
From: Konstantin Knizhnik
Date:
Subject: Problem with pg_atomic_compare_exchange_u64 at 32-bit platformwd