Re: pg_plan_advice - Mailing list pgsql-hackers

On Sat, Mar 14, 2026 at 11:06 AM Zsolt Parragi
<zsolt.parragi@percona.com> wrote:
> I noticed a difference between installed headers with make and meson,
> which is caused by pg_plan_advice.h. It is completely missing from the
> make build, and installs to the wrong location with meson.
>
> Please see the attached patch that fixes this.

Thanks. The changes to the Makefile seem to mirror what is done in
contrib/isn/Makefile, but I'm not so sure about the meson.build
changes. sepgsql uses dir_data / 'contrib' rather than
dir_include_server. src/pl/pl{perl,pgsql,python} use
dir_include_server, but they also live in src/pl, not contrib. I don't
think I understand what the underlying principal is supposed to be
here. If you or anyone else knows, please enlighten me.

--
Robert Haas
EDB: http://www.enterprisedb.com