Re: why does enum_endpoint call GetTransactionSnapshot()? - Mailing list pgsql-hackers

From Robert Haas
Subject Re: why does enum_endpoint call GetTransactionSnapshot()?
Date
Msg-id CA+TgmoaiFdrcenjWqAjtvrvSPWVAymoYUCmriaHJD1Xb7htqQg@mail.gmail.com
Whole thread Raw
In response to Re: why does enum_endpoint call GetTransactionSnapshot()?  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On Tue, Apr 28, 2015 at 9:28 PM, Bruce Momjian <bruce@momjian.us> wrote:
> On Sat, Feb 14, 2015 at 05:29:43PM -0500, Robert Haas wrote:
>> On Sat, Feb 14, 2015 at 5:12 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> > Robert Haas <robertmhaas@gmail.com> writes:
>> >> I think this is probably a holdover from before the death of
>> >> SnapshotNow, and that we should just pass NULL to
>> >> systable_beginscan_ordered() here, the same as we do for other catalog
>> >> accesses.  Barring objections, I'll go make that change.
>> >
>> > Seems reasonable to me, but why are you only looking at that one and
>> > not the identical code in enum_range_internal()?
>>
>> I noticed that one after hitting send.  I think we should change them both.
>
> Any news on this?

Done.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Shouldn't CREATE TABLE LIKE copy the relhasoids property?
Next
From: Robert Haas
Date:
Subject: Re: Replication identifiers, take 4