Re: tuplesort memory usage: grow_memtuples - Mailing list pgsql-hackers

From Robert Haas
Subject Re: tuplesort memory usage: grow_memtuples
Date
Msg-id CA+TgmoagNU24igYdAG2LVgTufZMyRkwshaK2zWDzLa=dL8GQfw@mail.gmail.com
Whole thread Raw
In response to Re: tuplesort memory usage: grow_memtuples  (Peter Geoghegan <peter@2ndquadrant.com>)
List pgsql-hackers
On Thu, Nov 15, 2012 at 4:13 PM, Peter Geoghegan <peter@2ndquadrant.com> wrote:
> On 15 November 2012 19:54, Greg Stark <stark@mit.edu> wrote:
>> The only concern I had was about the behaviour after it did the
>> special case. I didn't want it to keep doing the math and trying to
>> grow again a little bit every tuple. I think I was leaning to putting
>> the magic flag back.
>
> The alternative might just be to add a new constant to the
> TupSortStatus enum. That might be more logical.

That seems like a misfit to me, but throwing in "bool
cangrowmemtuples" or something like that seems like a good solution.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: tuplesort memory usage: grow_memtuples
Next
From: Andres Freund
Date:
Subject: Re: logical changeset generation v3 - comparison to Postgres-R change set format