Postgres Pro
Downloads
Home   >   mailing lists

Re: Reviewing freeze map code - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Reviewing freeze map code
Date
Msg-id CA+Tgmoad3c+yC9cHYSy9JMKUXT4OPhekmtPahELq4mA71qWHHA@mail.gmail.com
Whole thread Raw
In response to Re: Reviewing freeze map code  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: Reviewing freeze map code  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view 
On Sat, Jun 4, 2016 at 12:18 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> Attached updated patch.

The error-checking enhancements here look good to me, except that you
forgot to initialize totalBytesRead.  I've committed those changes
with a fix for that problem and will look at the rest of this
separately.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Sridhar N Bamandlapally
Date:
Subject: OUT parameter and RETURN table/setof
Next
From: Robert Haas
Date:
Subject: Re: Typo in parallel comment of heap_delete()