Re: Patch: add psql tab completion for event triggers - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Patch: add psql tab completion for event triggers
Date
Msg-id CA+TgmoaW2YYa_Fh=OvEZaRHrLQLHnJ7qfM7vtDFfmv6H6aOzuw@mail.gmail.com
Whole thread Raw
In response to Re: Patch: add psql tab completion for event triggers  (Ian Barwick <ian@2ndquadrant.com>)
Responses Re: Patch: add psql tab completion for event triggers  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On Wed, Apr 9, 2014 at 8:58 PM, Ian Barwick <ian@2ndquadrant.com> wrote:
> Apologies again, that was ill-thought out. Revised patch attached with only
> the additions related to event triggers, and the small fix for ALTER TRIGGER
> mentioned above which ensures "RENAME TO" is applied only when "ALTER
> TRIGGER <name> ON <sth>" was input; currently there is no check for a
> preceding "ALTER", resulting in the spurious "RENAME TO" when completing
> "CREATE EVENT TRIGGER".

OK, committed.

(I know this was submitted rather late, but I think we've often
allowed tab-completion fixups at similar times in past releases, since
they are quite mechanical.  If anyone feels that I shouldn't have
committed this, please advise.)

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Window function optimisation, allow pushdowns of items matching PARTITION BY clauses
Next
From: Robert Haas
Date:
Subject: Re: four minor proposals for 9.5