Re: checksum verification code breaks backups in v16- - Mailing list pgsql-hackers

From Robert Haas
Subject Re: checksum verification code breaks backups in v16-
Date
Msg-id CA+TgmoaV43sD=s6t7ksJ8Ti-o716r4GpVVWGLguEnTtczfFOTg@mail.gmail.com
Whole thread Raw
In response to Re: checksum verification code breaks backups in v16-  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: checksum verification code breaks backups in v16-
List pgsql-hackers
On Tue, Dec 3, 2024 at 5:26 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
> On Tue, Dec 03, 2024 at 11:39:43AM -0500, Robert Haas wrote:
> > If we want a narrower and thus less-risky fix, we could consider just
> > adjusting this code here:
> >
> >                 segmentno = atoi(segmentpath + 1);
> >                 if (segmentno == 0)
> >                     ereport(ERROR,
> >                             (errmsg("invalid segment number %d in file \"%s\"",
> >                                     segmentno, filename)));
>
> I'm only seeing this code in pg_checksums.  Is that what you are proposing
> to change?

No. This code is present in src/backend/backup/basebackup.c in REL_16_STABLE.

--
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Replace current implementations in crypt() and gen_salt() to OpenSSL
Next
From: Daniel Gustafsson
Date:
Subject: Re: Replace current implementations in crypt() and gen_salt() to OpenSSL