Postgres Pro
Downloads
Home   >   mailing lists

Re: Avoid index rebuilds for no-rewrite ALTER TABLE ALTER TYPE - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Avoid index rebuilds for no-rewrite ALTER TABLE ALTER TYPE
Date
Msg-id CA+TgmoaUAgevL-wRcn2OcgOLjdUS8UJHyb6tbENKkL5UETp9TA@mail.gmail.com
Whole thread Raw
In response to Re: Avoid index rebuilds for no-rewrite ALTER TABLE ALTER TYPE  (Noah Misch <noah@2ndQuadrant.com>)
Responses Re: Avoid index rebuilds for no-rewrite ALTER TABLE ALTER TYPE
List pgsql-hackers
Tree view 
On Wed, Jul 6, 2011 at 2:50 PM, Noah Misch <noah@2ndquadrant.com> wrote:
> Drat; fixed in this version.  My local branches contain a large test battery
> that I filter out of the diff before posting.  This time, that filter also
> removed an essential part of the patch.

OK, I'm pretty happy with this version, with the following minor caveats:

1. I still think the documentation changes could use some
word-smithing.  If I end up being the one who commits this, I'll take
a look at that as part of the commit.

2. I think it would be helpful to add a comment explaining why
CheckIndexCompatible() is calling

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Latch implementation that wakes on postmaster death on both win32 and Unix
Next
From: Robert Haas
Date:
Subject: Re: Avoid index rebuilds for no-rewrite ALTER TABLE ALTER TYPE