Postgres Pro
Downloads
Home   >   mailing lists

Re: Forbid referencing columns by names in ALTER INDEX ... SET STATISTICS - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Forbid referencing columns by names in ALTER INDEX ... SET STATISTICS
Date
Msg-id CA+TgmoaRfm_byKQR7A1CrOs0Z9QiLZYmYHe2b8Jq909iLLMtoQ@mail.gmail.com
Whole thread Raw
In response to Forbid referencing columns by names in ALTER INDEX ... SETSTATISTICS  (Yugo Nagata <nagata@sraoss.co.jp>)
Responses Re: Forbid referencing columns by names in ALTER INDEX ... SETSTATISTICS
List pgsql-hackers
Tree view 
On Wed, Jun 27, 2018 at 9:22 AM, Yugo Nagata <nagata@sraoss.co.jp> wrote:
> According to the syntax in ALTER INDEX doc, a column should be specified by
> column number as discussed in [1]. However, the current code still allows to
> use an internal column name like "expr". Is this intentional?
>
> Although it is harmless, how about forbiding this undocumented and
> unuseful behavior. The attached patch does it.

If it's harmless, why prohibit it?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Alexander Kuzmenkov
Date:
Subject: Re: Generating partitioning tuple conversion maps faster
Next
From: Alvaro Herrera
Date:
Subject: Re: Tips on committing