On Sat, Apr 4, 2015 at 10:27 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I see nothing in the win32 stuff that tries to define USE_FLOAT8_BYVAL
>> on 64-bit windows, is this just an oversight or does it not actually
>> work there? or is it for on-disk compatibility with 32-bit windows?
>
> That flag doesn't affect on-disk compatibility. It could certainly break
> third-party extensions, but we accept the same hazard on non-Windows with
> equanimity. I suspect this point simply wasn't revisited when we added
> support for 64-bit Windows.
>
> Having said that, I'm fine with leaving this as-is, if only because
> it means we're exercising the --disable-float8-byval code paths in
> the buildfarm ;-)
But... are we? I mean, I don't see anything in the Windows code that
defines USE_FLOAT8_BYVAL.
(Admittedly, if we're not, I have no theory for why that patch fixed
anything, but all the same I don't see where it's getting defined.)
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
