Re: pgstat_reset_remove_files ignores its argument - Mailing list pgsql-hackers

From Robert Haas
Subject Re: pgstat_reset_remove_files ignores its argument
Date
Msg-id CA+Tgmoa+0F7fnY7v1PZZarK4hd07r48yCbg1R+KSXbzYzdAoVw@mail.gmail.com
Whole thread Raw
In response to pgstat_reset_remove_files ignores its argument  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: pgstat_reset_remove_files ignores its argument  (Tomas Vondra <tv@fuzzy.cz>)
Re: pgstat_reset_remove_files ignores its argument  (Jeff Janes <jeff.janes@gmail.com>)
List pgsql-hackers
On Wed, Aug 14, 2013 at 12:13 AM, Jeff Janes <jeff.janes@gmail.com> wrote:
> in 9.3 and 9.4, pgstat_reset_remove_files uses the global variable
> pgstat_stat_directory rather than the argument it is passed, "directory".
> On crash recovery, this means the tmp directory gets cleared twice and the
> permanent pg_stat doesn't get cleared at all.
>
> It seems like the obvious one line change would fix it, but I haven't tested
> it because I don't know how to cause a crash without pg_stat already being
> empty.

I think there are three lines to change, as in the attached patch.

Am I wrong?

...Robert

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [PATCH] pg_sleep(interval)
Next
From: Tomas Vondra
Date:
Subject: Re: pgstat_reset_remove_files ignores its argument