Re: es_query_dsa is broken - Mailing list pgsql-hackers

From Robert Haas
Subject Re: es_query_dsa is broken
Date
Msg-id CA+TgmoZxbTS8hM6bm-1i_mZ_KLgRrNVO7aAG3wtyOzMUQSUEEg@mail.gmail.com
Whole thread Raw
In response to Re: es_query_dsa is broken  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
On Sun, Dec 17, 2017 at 7:35 PM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> Andreas Seltenreich found a query[1] that suffers from this bug
> (thanks!), and Amit confirmed that this patch fixes it, but further
> sqlsmith fuzz testing with the patch applied also revealed that it
> failed to handle the case where pei is NULL because parallelism was
> inhibited.  Here's a new version to fix that.  Someone might prefer a
> coding with "if" rather than the ternary operator, but I didn't have a
> strong preference.

Looks OK to me.  Committed and back-patched to v10.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Protect syscache from bloating with negative cache entries
Next
From: "Bossart, Nathan"
Date:
Subject: Re: BUG #14941: Vacuum crashes