Re: Statistics Import and Export - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Statistics Import and Export
Date
Msg-id CA+TgmoZwaLN9FzvMBW-2Yg_6PeenDhEg-8BRYX+yj8pSPcQ1aQ@mail.gmail.com
Whole thread Raw
In response to Re: Statistics Import and Export  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: Statistics Import and Export
List pgsql-hackers
On Wed, Feb 26, 2025 at 3:37 PM Jeff Davis <pgsql@j-davis.com> wrote:
> On Wed, 2025-02-26 at 15:15 -0500, Robert Haas wrote:
> > I strongly agree. I think shipping this feature in any form that uses
> > in-place updates is a bad idea.
>
> Removed already in commit f3dae2ae58.

Cool.

> The reason they were added was mostly for consistency with ANALYZE, and
> (at least for me) secondarily about churn on pg_class. The bloat was
> never terrible.
>
> With that in mind, should we remove the in-place updates from ANALYZE
> as well?

While I generally think fewer in-place updates are better than more,
I'm not sure what code we're talking about here and I definitely
haven't studied it, so I don't want to make excessively strong
statements. If you feel it can be done without breaking anything else,
or you have a way to repair the breakage, I'd definitely be interested
in hearing more about that.

--
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: "Devulapalli, Raghuveer"
Date:
Subject: RE: Improve CRC32C performance on SSE4.2
Next
From: Alex Friedman
Date:
Subject: Re: Doc: clarify possibility of ephemeral discrepancies between state and wait_event in pg_stat_activity