On Thu, Oct 13, 2011 at 12:46 PM, Kohei KaiGai <kaigai@kaigai.gr.jp> wrote:
> And, also I added regression test cases to detect these code paths,
> because some of object types does not cover the case when it was
> dropped.
These regression tests seem busted to me. First, I applied the part 2
patch. The regression tests failed. Then, I applied the part 3
patch. Then they passed. So far so good. Then, I took the
regression test portion of the part 2 and part 3 patches and applied
just those. That also fails.
Can we come up with a set of regression tests that:
- passes on unmodified master
- still passes with the part 2 patch applied
- also passes with both the part 2 and part 3 patches applied
AIUI, this patch isn't supposed to be changing any behavior, just
consolidating the code.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
