Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] hstore_to_json: empty hstores must return empty json objects - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [PATCH] hstore_to_json: empty hstores must return empty json objects
Date
Msg-id CA+TgmoZjMKZ_k5o6j4cpynwjx2jcoj8TTxtP0yiVcYn5m6U=7g@mail.gmail.com
Whole thread Raw
In response to [PATCH] hstore_to_json: empty hstores must return empty json objects  (Oskari Saarenmaa <os@ohmu.fi>)
Responses Re: [PATCH] hstore_to_json: empty hstores must return empty json objects  (Merlin Moncure <mmoncure@gmail.com>)
Re: [PATCH] hstore_to_json: empty hstores must return empty json objects  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Tree view 
On Wed, Oct 16, 2013 at 12:02 PM, Oskari Saarenmaa <os@ohmu.fi> wrote:
> hstore_to_json used to return an empty string for empty hstores, but
> that is not correct as an empty string is not valid json and calling
> row_to_json() on rows which have empty hstores will generate invalid
> json for the entire row.  The right thing to do is to return an empty
> json object.

Hmm.  This sure looks like a bug to me.

Anyone think otherwise?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: ERROR : 'tuple concurrently updated'
Next
From: Robert Haas
Date:
Subject: Re: Auto-tuning work_mem and maintenance_work_mem