Re: pgsql: Recursively fsync() the data directory after a crash. - Mailing list pgsql-committers

From Robert Haas
Subject Re: pgsql: Recursively fsync() the data directory after a crash.
Date
Msg-id CA+TgmoZgU7phQDPP7jm6gQ3N5u67Vp7FLiJ56M6dv9TD_+W97w@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Recursively fsync() the data directory after a crash.  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-committers
On Mon, May 4, 2015 at 11:37 PM, Andrew Dunstan <andrew@dunslane.net> wrote:
> On 05/04/2015 02:23 PM, Robert Haas wrote:
>> Recursively fsync() the data directory after a crash.
>>
>> Otherwise, if there's another crash, some writes from after the first
>> crash might make it to disk while writes from before the crash fail
>> to make it to disk.  This could lead to data corruption.
>>
>> Back-patch to all supported versions.
>>
>
> This appears to have broken Windows builds. At least it's broken by using
> the two argument form of open instead of the three argument form, for which
> we have a #define in the win32 case, and pg_win32_is_junction is a typo -
> the first _ should not be there.

Sorry about that.  Working on it now.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Recursively fsync() the data directory after a crash.
Next
From: Robert Haas
Date:
Subject: pgsql: Fix some problems with patch to fsync the data directory.