Re: pg_amcheck contrib application - Mailing list pgsql-hackers

From Robert Haas
Subject Re: pg_amcheck contrib application
Date
Msg-id CA+TgmoZUONCkdcdR778EKuE+f1r5Obieu63db2OgMPHaEvEPTQ@mail.gmail.com
Whole thread Raw
In response to Re: pg_amcheck contrib application  (Mark Dilger <mark.dilger@enterprisedb.com>)
Responses Re: pg_amcheck contrib application
List pgsql-hackers
On Fri, Apr 30, 2021 at 3:26 PM Mark Dilger
<mark.dilger@enterprisedb.com> wrote:
> It looks mostly good to me.  There is a off-by-one error introduced with:
>
> -   else if (chunkno != (endchunk + 1))
> +   else if (expected_chunk_seq < last_chunk_seq)
>
> I think that needs to be
>
> +  else if (expected_chunk_seq <= last_chunk_seq)
>
> because otherwise it won't complain if the only missing chunk is the very last one.

OK, how about this version?

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Mark Dilger
Date:
Subject: Re: pg_amcheck contrib application
Next
From: Peter Geoghegan
Date:
Subject: Re: MaxOffsetNumber for Table AMs