MV patch broke users of ExplainOneQuery_hook - Mailing list pgsql-hackers

From Robert Haas
Subject MV patch broke users of ExplainOneQuery_hook
Date
Msg-id CA+TgmoZTjoBh40gZd8CoyWbwfUhNtLXF+nA0nG6P8FNhcThfGQ@mail.gmail.com
Whole thread Raw
Responses Re: MV patch broke users of ExplainOneQuery_hook
Re: MV patch broke users of ExplainOneQuery_hook
List pgsql-hackers
The materialized views patch adjusted ExplainOneQuery to take an
additional DestReceiver argument, but failed to add a matching
argument to the definition of ExplainOneQuery_hook.  This makes the
hook unusable.  The idea of this hook is that your hook function will
do something before and/or after calling pg_plan_query and
ExplainOnePlan.  But this no longer works, because ExplainOnePlan
needs the DestReceiver, which hasn't been exposed to the hook.   :-(

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Rodrigo Barboza
Date:
Subject: Re: Unrecognized type error (postgres 9.1.4)
Next
From: Kevin Grittner
Date:
Subject: Re: MV patch broke users of ExplainOneQuery_hook