Re: fun with "Ready for Committer" patches - Mailing list pgsql-hackers

From Robert Haas
Subject Re: fun with "Ready for Committer" patches
Date
Msg-id CA+TgmoZQYqucmZM9x8Vsih65L_RscJx4K88orUs5ak2jn8CSRA@mail.gmail.com
Whole thread Raw
In response to Re: fun with "Ready for Committer" patches  (Craig Ringer <craig@2ndquadrant.com>)
Responses Re: fun with "Ready for Committer" patches
List pgsql-hackers
On Tue, Mar 8, 2016 at 9:44 PM, Craig Ringer <craig@2ndquadrant.com> wrote:
> On 9 March 2016 at 07:18, Tatsuo Ishii <ishii@postgresql.org> wrote:
>> Many of "needs review" state patches already have reviewer(s). Do you
>> mean we want more reviewers in addition to them for such patches?
>
> Yeah. Personally I'm not too confident about what precisely is required to
> move a patch from needs-review to ready-for-committer. I've done a chunk of
> review for a number of patches, but I'm not always confident saying "all
> clear, proceed".

I think that if you've done your best to review it, and you don't see
any remaining problems, you should mark it Ready for Committer.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: fun with "Ready for Committer" patches
Next
From: Robert Haas
Date:
Subject: Re: Parallel Aggregate