Re: [patch] psql tab completion for grant execute - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [patch] psql tab completion for grant execute
Date
Msg-id CA+TgmoZKq4KFAtOR2LJv0jXXOUuVOY7hRTS1V3ttfn3AsX55+w@mail.gmail.com
Whole thread Raw
In response to [patch] psql tab completion for grant execute  ("Daniel Verite" <daniel@manitou-mail.org>)
Responses Re: [patch] psql tab completion for grant execute
List pgsql-hackers
On Mon, Aug 17, 2015 at 5:07 PM, Daniel Verite <daniel@manitou-mail.org> wrote:
> When tab-completing after GRANT EXECUTE, currently psql injects
> "PROCEDURE", rather than the expected "ON".
>
> The code for completing with "ON" is there, but it's not reached due to
> falling earlier into another branch, one that handles CREATE TRIGGER.
>
> A trivial patch is attached. It adds the condition that if EXECUTE is
> preceded by GRANT itself preceded by nothing, then that completion
> with PROCEDURE is skipped.

Thanks, I committed this.  I don't think we usually back-patch tab
completion fixes, but I back-patched this one to 9.5 anyway, so that
it gets out into the wild a little sooner.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Proposal: Implement failover on libpq connect level.
Next
From: Peter Eisentraut
Date:
Subject: Re: allowing wal_level change at run time