Request a Demo
Home   >   mailing lists

Re: Avoid resource leak (src/test/modules/test_binaryheap/test_binaryheap.c) - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Avoid resource leak (src/test/modules/test_binaryheap/test_binaryheap.c)
Date
Msg-id CA+TgmoZKR-CR95rtOVH1eNKy+M-ZvngOyyoM_zQLYbt+70ezvQ@mail.gmail.com
Whole thread Raw
In response to Avoid resource leak (src/test/modules/test_binaryheap/test_binaryheap.c)  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: Avoid resource leak (src/test/modules/test_binaryheap/test_binaryheap.c)
List pgsql-hackers
Tree view 
On Fri, Sep 12, 2025 at 1:54 PM Ranier Vilela <ranier.vf@gmail.com> wrote:
> Per Coverity.
>
> Coverity reports this resource leak in test_binaryheap module.
> I think that is right.
>
> Trivial patch attached.

If this were correct, we'd need to also free the memory in all the
error paths. But of course, in both error and non-error paths, we rely
on memory context cleanup to free memory for us, except in cases where
there's some specific reason to believe that's not good enough. I
doubt that there is any such reason in this case.

See src/backend/utils/mmgr/README

--
Robert Haas
EDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: "Chiranmoy.Bhattacharya@fujitsu.com"
Date:
Subject: Re: [PATCH] Hex-coding optimizations using SVE on ARM.
Next
From: "Jonathan S. Katz"
Date:
Subject: Re: PostgreSQL 18 GA press release draft