Re: Emit extra debug message when executing extension script. - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Emit extra debug message when executing extension script.
Date
Msg-id CA+TgmoZDeNN4F89R1RFZU0eaROL4yGYTpdJ3B+cdirYoYmKc2A@mail.gmail.com
Whole thread Raw
In response to Re: Emit extra debug message when executing extension script.  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Emit extra debug message when executing extension script.
List pgsql-hackers
On Mon, Jul 4, 2022 at 5:27 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> On 2022-Jun-29, Robert Haas wrote:
> > On Wed, Jun 29, 2022 at 9:26 AM Peter Eisentraut
> > <peter.eisentraut@enterprisedb.com> wrote:
> > > On 28.06.22 21:10, Jeff Davis wrote:
> > > > +     ereport(DEBUG1, errmsg("executing extension script: %s", filename));
> > >
> > > This should either be elog or use errmsg_internal.
> >
> > Why?
>
> The reason is that errmsg() marks the message for translation, and we
> don't want to burden translators with messages that are of little
> interest to most users.  Using either elog() or errmsg_internal()
> avoids that.

Yeah, I'm aware of that in general, but I'm not quite clear on how we
decide that. Do we take the view that all debug-level messages need
not be translated?

-- 
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: PSA: Autoconf has risen from the dead
Next
From: James Coleman
Date:
Subject: Re: pg_rewind: warn when checkpoint hasn't happened after promotion