Re: tuplesort Generation memory contexts don't play nicely with index builds - Mailing list pgsql-hackers

From Robert Haas
Subject Re: tuplesort Generation memory contexts don't play nicely with index builds
Date
Msg-id CA+TgmoZ=z2g3d8Rxu3uiZYoi6J3KdeJhWCVs81dGGhkYfD9Yiw@mail.gmail.com
Whole thread Raw
In response to Re: tuplesort Generation memory contexts don't play nicely with index builds  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
On Tue, Jul 5, 2022 at 9:34 PM David Rowley <dgrowleyml@gmail.com> wrote:
> I voiced my dislike for the patch I came up with to fix this issue to
> Andres.  He suggested that I just add a version of index_form_tuple
> that can be given a MemoryContext pointer to allocate the returned
> tuple into.
>
> I like that idea much better, so I've attached a patch to fix it that way.
>
> If there are no objections, I plan to push this in the next 24 hours.

Apologies for not having looked at this thread sooner, but for what
it's worth, I think this is a fine solution.

Thanks,

-- 
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: automatically generating node support functions
Next
From: Nathan Bossart
Date:
Subject: pg_parameter_aclcheck() and trusted extensions