Re: Bogus error handling in pg_upgrade - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Bogus error handling in pg_upgrade
Date
Msg-id CA+TgmoZ906vzALT4KvSeGvO8dJchqt5bp+4LpObeUB3KWwyz+A@mail.gmail.com
Whole thread Raw
In response to Bogus error handling in pg_upgrade  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sun, Dec 29, 2013 at 12:25 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> check_ok() is particularly badly named, since it contains not one iota
> of error checking.  misleadingly_claim_ok() would be a better name.

That's pretty hilarious, actually.  I think it probably started as a
copy of initdb.c's check_ok(), and then at some point along the line
it got its heart ripped out.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: preserving forensic information when we freeze
Next
From: Robert Haas
Date:
Subject: Re: Planning time in explain/explain analyze