Re: blkreftable.c needs more sanity checks - Mailing list pgsql-hackers

From Robert Haas
Subject Re: blkreftable.c needs more sanity checks
Date
Msg-id CA+TgmoZ6rgU8KtCKEhcajMzc0t+BvT7L2JqdhiUpDTejd9c4bw@mail.gmail.com
Whole thread
In response to Re: blkreftable.c needs more sanity checks  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On Tue, Jul 14, 2026 at 7:31 AM Daniel Gustafsson <daniel@yesql.se> wrote:
> A more likely scenario is that you are hacking in this code and have made silly
> errors.  It mostly seemed consistent with how the forknum error is reported,
> but is not important.

Upon reflection, it occurred to me that I would probably rather have
the chunk offset than the chunk size if this ever trips, so I added
both to the error message. Here's v2.

> No disagreement there, which is why I tried to get it reviewed quickly so it
> can be applied and forgotten about and we can move on to more important
> matters.

Thanks for reviewing.

--
Robert Haas
EDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: Enforce INSERT RLS checks for FOR PORTION OF leftovers?
Next
From: Nathan Bossart
Date:
Subject: Re: SQL:2011 Application Time Update & Delete