Re: [bug] relcache leaks in get_object_address - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [bug] relcache leaks in get_object_address
Date
Msg-id CA+TgmoZ30Cr-s02h97vz=8v+vj-FdTtWu6hOAyzBe3w-YopwvA@mail.gmail.com
Whole thread Raw
In response to Re: [bug] relcache leaks in get_object_address  (Kohei KaiGai <kaigai@kaigai.gr.jp>)
List pgsql-hackers
On Thu, Oct 13, 2011 at 12:27 PM, Kohei KaiGai <kaigai@kaigai.gr.jp> wrote:
> The attached patch fixes this problem.
> Unfortunately, we have no code that invokes get_object_address()
> with missing_ok = true now, so please apply a couple of patches
> to rework DROP statement of mine.
>
> DROP TRIGGER no_such_trigger ON existing_table;
>
> shall cause a relcache reference leaks, without this patch.

We could argue that that's a bug in your drop reworks rather than the
existing code, but I'm willing to go along with this approach, so,
committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: patch for new feature: Buffer Cache Hibernation
Next
From: Alvaro Herrera
Date:
Subject: Re: Isolation tests still falling over routinely