Re: [v9.2] make_greater_string() does not return a string in some cases - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [v9.2] make_greater_string() does not return a string in some cases
Date
Msg-id CA+TgmoZ+3gv=x7ScvFbJgE4pywRfy8QQ=ymDvKoRoWxVDGPWjQ@mail.gmail.com
Whole thread Raw
In response to Re: [v9.2] make_greater_string() does not return a string in some cases  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, Oct 18, 2011 at 12:11 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Mon, Oct 17, 2011 at 11:54 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> http://www.faqs.org/rfcs/rfc3629.html
>
>> I'm still confused.  The input string is already known to be valid
>> UTF-8, so the second byte (if there is one) must be between 0x80 and
>> 0xBF.  Therefore it will be neither 0xED nor 0xF4.
>
> I haven't read the patch lately, but ED and F4 are special as *first*
> bytes.  Maybe the logic isn't quite right, or you read it wrong?

I think I'll let the patch author comment on that.  It looks wrong to
me, but I just work here.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: new compiler warnings
Next
From: Tom Lane
Date:
Subject: Re: new compiler warnings